-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug from generation of model names #4817
Conversation
bc9bdc0
to
cf0b654
Compare
There are failing tests for correcting the package name casing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkodev can you queue a smoke generation to ensure this fixes the problem please?
Also I'd like us to add retract directives for the impacted versions.
https://go.dev/ref/mod#go-mod-file-retract
Quality Gate passedIssues Measures |
Smoke generation with the fix https://github.com/microsoftgraph/msgraph-sdk-go/blob/v1.0/pipelinebuild/154506/users/item_get_member_groups_response.go#L12 |
Models that were flattened, i.e moved from deeper packages to level 2 pakages relied on the package names to prefix the deeper model name. Chnages introduced by package name case normalization affecting camel casing in names.
This resolves microsoftgraph/msgraph-sdk-go#721