Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the RPC server to respect the KIOTA_CONFIG_PREVIEW flag. #4594

Merged
merged 6 commits into from
May 3, 2024

Conversation

andrueastman
Copy link
Member

Isolates RPC server changes in #4500 to respect the KIOTA_CONFIG_PREVIEW

This should ideally not affect the extension as it would need to pass the flag for it generate a workspace/plugins.

@andrueastman andrueastman requested a review from a team as a code owner May 2, 2024 14:35
baywet
baywet previously requested changes May 2, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@andrueastman andrueastman enabled auto-merge May 3, 2024 06:29
auto-merge was automatically disabled May 3, 2024 06:33

Pull Request is not mergeable

@andrueastman andrueastman enabled auto-merge May 3, 2024 06:34
@andrueastman andrueastman requested a review from baywet May 3, 2024 06:34
@andrueastman andrueastman dismissed baywet’s stale review May 3, 2024 06:34

Changes addressed

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled May 3, 2024 09:30

Pull Request is not mergeable

@baywet baywet merged commit b144010 into main May 3, 2024
207 checks passed
@baywet baywet deleted the andrueastman/isolateRPC branch May 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants