Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape all special suffixes in go file names #4540

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Escape all special suffixes in go file names #4540

merged 3 commits into from
Apr 23, 2024

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Apr 23, 2024 •
edited by baywet
Loading

fixes #4407
Escape all special suffixes in go file names

@rkodev rkodev requested a review from a team as a code owner April 23, 2024 08:12
andrueastman
andrueastman reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a changelog entry?

src/Kiota.Builder/PathSegmenters/GoPathSegmenter.cs Outdated Show resolved Hide resolved
@baywet baywet enabled auto-merge April 23, 2024 12:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet merged commit aab71e0 into main Apr 23, 2024
205 of 206 checks passed
@baywet baywet deleted the feat/go_escape_special_filenames branch April 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go files names should not end with _windows.go
3 participants
@rkodev @andrueastman @baywet