Fixes template re-use. #4459
Merged
Fixes template re-use. #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SilasKenneth
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to microsoftgraph/msgraph-sdk-dotnet#2384 and microsoftgraph/msgraph-sdk-dotnet#2335
This PR is a follow up to #4154,
It tweaks the use generating URL Template parameters to only be unique for an operation when a required parameter is present across the operations. (This results in 15% decrease in user strings in the V1 SDK package of graph). This enables scenarios where a URL template passed to the constructor of a request builder can be used across operations without having to be redefined as well.