Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that stream responses don't generate paging code #4210

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Check that stream responses don't generate paging code #4210

merged 4 commits into from
Feb 22, 2024

Conversation

calebkiage
Copy link
Contributor

Closes #4207

@calebkiage calebkiage requested a review from a team as a code owner February 21, 2024 18:10
andrueastman
andrueastman reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can update the changelog before merge? Otherwise, looks good to me.

@calebkiage calebkiage enabled auto-merge (squash) February 22, 2024 12:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@calebkiage calebkiage merged commit 9e5b62c into main Feb 22, 2024
185 of 186 checks passed
@calebkiage calebkiage deleted the fix/paging-on-streams branch February 22, 2024 12:26
@baywet baywet modified the milestone: Kiota v1.12 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI generation build failure when an API has paging information but no response body schema
3 participants
@calebkiage @andrueastman @baywet