Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add client #4164

Merged
merged 32 commits into from
Feb 29, 2024
Merged

feature/add client #4164

merged 32 commits into from
Feb 29, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Feb 9, 2024 •
edited
Loading

partial #3356, implements add command

TODOs:

  • implement skip generation
  • check message hints
  • implement description copy to kiota folder
  • implement unit tests

@baywet baywet self-assigned this Feb 9, 2024
Base automatically changed from feature/config-init to main February 12, 2024 06:53
@baywet baywet force-pushed the feature/add-client branch from 66d588a to 5e90fe5 Compare February 12, 2024 21:31
@baywet baywet force-pushed the feature/add-client branch 3 times, most recently from 31e3c43 to 97d6cc6 Compare February 27, 2024 16:14
baywet added 24 commits February 28, 2024 09:47
@baywet
- adds all add command options
c1e82dd
@baywet
- adds additional mapping to the configuration class so we can effici…
0d2dbf7 
…ently switch context

Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds a level of indirection between builder and lock
63411d9 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- initial implementation of backing/restore for config
0173370 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- initial wiring of config file generation
03b1843 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- initial implementation of manifest generation
55e73d5 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes formatting
0d48df1
@baywet
- adds support for emiting requests in manifest
ac9474a 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- implements configuration hash
578d0a1 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- normalizes output path to a relative path
3179095 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds support for skip generation
1c2f9d0 
- adds check whether client is present when adding

Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes hints for kiota add command
0cf277c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes formatting
ac9f89e 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds workspace save of description
b3b30ad 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes formatting
56732d8
@baywet
- fixes failing unit tests
e539f90 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes an error swallowing issue when parsing media types
9f0bf8d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds unit tests for client configuration
c8629bc 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixed a bug with random string collections comparisons
75c8261 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds unit tests for client configuration comparer
033fc1c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes formatting
7339b4c
@baywet
- adds unit tests for request info comparer
5346a06 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds missing unit tests for structured mime type collection
c7b5d08 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- typo fix
7d95983 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet force-pushed the feature/add-client branch from 66d3889 to 179c4c8 Compare February 28, 2024 15:25
@baywet baywet marked this pull request as ready for review February 28, 2024 15:25
@baywet baywet requested a review from a team as a code owner February 28, 2024 15:25
@baywet baywet enabled auto-merge February 28, 2024 15:26
@baywet baywet requested a review from andrueastman February 29, 2024 15:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled February 29, 2024 15:32

Pull Request is not mergeable

@baywet baywet merged commit fbffef5 into main Feb 29, 2024
191 checks passed
@baywet baywet deleted the feature/add-client branch February 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman