- fixes a deadlock when evicting cached descriptions

[baywet]

follow up to #4046 CC @MarkCiliaVincenti

[baywet]

@MarkCiliaVincenti this bug was revealed by the recent change. The previous library guarded against re-entrant calls. It'd be nice to have the same feature in this new library.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[MarkCiliaVincenti]

@MarkCiliaVincenti this bug was revealed by the recent change. The previous library guarded against re-entrant calls. It'd be nice to have the same feature in this new library.

Lock re-entrancy and asynchronous code do not mix well. Some call it impossible (to get perfect) https://itnext.io/reentrant-recursive-async-lock-is-impossible-in-c-e9593f4aa38a

And Stephen Cleary also recommends refactoring to avoid it. https://blog.stephencleary.com/2013/04/recursive-re-entrant-locks.html

I should have made this behaviour clear in my description and also in my documentation. Something to work on this weekend perhaps.

Apologies for causing this issue.

[baywet]

no worries, nothing major, we'll roll out a patch once this is merged.
I looped you in the fix in case you could improve your library (either through docs, or through changes), that's it. I understand that tracking re-entrances is complex to implement/costly at best.