VS Code extension: show children nodes when filtering #4030
Conversation
There was a problem hiding this comment.
Thanks for looking into this. Yes I've pulled my hair a lot on the tree view and the visibility.
From what I can remember it seems that in some cases the refresh triggers a partial re-render for some reason.
So I'd suggest you set breaking points to double check whether the getCollaspedState method is called as expected, and returns the expected value for nodes.
Additionally, looking at the documentation I can see a difference in implementation which might or not have an impact.
L272, the property should be readonly.
Which means L250 we won't be able to set it externally, which means we need an optional parameter for getCollaspedState to pass an overriding value when needed.
I hope all of that helps debug things. Let me know if you have further questions.
I find it extremely confusing when they were filtered out.
The idea is to expand nodes up to the filtered node (so it's visible), but collapse itself and its children (to avoid clutter).
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Fixes #3998.
When filtering, it shows all children nodes, but the filtering target is collapsed.
Visibility works really well IMO, but there is some problem with collapsing nodes - it works overall, but not straight away. 🤷 I'm confused. :(