Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translations to vscode extension #4027

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

treastrain
Copy link
Contributor

Hello, I would like to propose to add Japanese support for Kiota's Visual Studio Code Extension.

@treastrain treastrain requested a review from a team as a code owner January 18, 2024 18:47
@treastrain
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @treastrain

@treastrain
Copy link
Contributor Author

Thanks for the approval! But some checks seem to be failing, are these caused by my commits...?

@andrueastman
Copy link
Member

No its not. We'll merge this and follow up on the issue with the description at https://developers.pipedrive.com/docs/api/v1/openapi.yaml via #4028

@andrueastman andrueastman merged commit 2216abc into microsoft:main Jan 19, 2024
179 of 186 checks passed
@treastrain treastrain deleted the support-japanese branch January 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants