[Go] Detect and fix model names with clashing constructor #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
changed the title
baywet
requested changes
Dec 19, 2023
Co-authored-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
reviewed
Dec 20, 2023
baywet
previously approved these changes
Dec 20, 2023
Signed-off-by: Vincent Biret <[email protected]>
baywet
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3920
It's the "quick and dirty" fix, we need a deeper review to properly remove the name mangling from the Writers ...