Free Java form enum reflection #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Nov 22, 2023
test in ci clean ci jobs cleanup and changelog update with the latest encoding minor cleanup Update src/Kiota.Builder/Writers/Java/CodeMethodWriter.cs Co-authored-by: Vincent Biret <[email protected]> - adds changelog entry for java enum
baywet
force-pushed
the
java-no-enum-reflection
branch
from
b7c8f04 to
7195b61
Compare
|
Let me have a look at the CI failure, seems legit. |
|
FYI I rebased, squashed and force pushed your branch before you pull. |
|
@baywet finished it up, sorry for the delay! Note: super happy about the integration tests catching it! |
baywet
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are the changes to align with:
microsoft/kiota-java#843