Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python/bugfix path parameters naming #3613

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Python/bugfix path parameters naming #3613

merged 3 commits into from
Nov 1, 2023

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Nov 1, 2023 •
edited
Loading

Fixes #3612
Related to microsoftgraph/msgraph-sdk-python#408

Sets path parameter keys to the parameter's SerializationName for consistency with url template

@samwelkanda samwelkanda marked this pull request as ready for review November 1, 2023 00:04
@samwelkanda samwelkanda requested a review from a team as a code owner November 1, 2023 00:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@samwelkanda samwelkanda merged commit 32fbdce into main Nov 1, 2023
170 of 173 checks passed
@samwelkanda samwelkanda deleted the python/bugfix-path-parameters-naming branch November 1, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python = Path parameters not set in url
2 participants
@samwelkanda @andrueastman