Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilda added to SpelledOutSymbols #3500 #3510

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Tilda added to SpelledOutSymbols #3500 #3510

merged 4 commits into from
Oct 19, 2023

Conversation

iozcelik
Copy link
Contributor

@iozcelik iozcelik commented Oct 17, 2023

fixes #3500

@iozcelik iozcelik requested a review from a team as a code owner October 17, 2023 18:14
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Can you add an entry to the changelog please ? (unreleased, added)
Can you add a case to the unit tests to avoid regressions please?

src/Kiota.Builder/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Oct 19, 2023

@iozcelik gentle reminder if you want this fix to be part of today's preview :)

@iozcelik
Copy link
Contributor Author

I added unit test and fix type to "tilde".

@iozcelik
Copy link
Contributor Author

iozcelik commented Oct 19, 2023

@iozcelik please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@iozcelik
Copy link
Contributor Author

iozcelik commented Oct 19, 2023

@iozcelik gentle reminder if you want this fix to be part of today's preview :)

Sorry, I'm out of city today. So, I made fixes, I hope :) @baywet

@baywet
Copy link
Member

baywet commented Oct 19, 2023

@iozcelik no worries, this can wait until the next preview. We're still missing the CLA agreement as far as I can tell. Thanks!

@iozcelik
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet enabled auto-merge October 19, 2023 20:31
@baywet baywet merged commit 3f35b41 into microsoft:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# convert special chars to enum
2 participants