Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS Code file #3376

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Fix TS Code file #3376

merged 6 commits into from
Oct 3, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Sep 26, 2023 •
edited
Loading

fixes #3419

  • Fixes linting in codefiles
  • Fixsing missing functions in codefiles

This was referenced Sep 26, 2023
Closed
Closed
baywet
baywet requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround. When this is tested, can you also add a changelog entry please?

@baywet baywet mentioned this pull request Oct 3, 2023
Closed
@rkodev rkodev marked this pull request as ready for review October 3, 2023 16:46
@rkodev rkodev requested a review from a team as a code owner October 3, 2023 16:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rkodev rkodev merged commit beadfaa into main Oct 3, 2023
172 of 173 checks passed
@rkodev rkodev deleted the fix/code-files branch October 3, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees

@rkodev rkodev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in generation of TypeScript codefiles
2 participants
@rkodev @baywet