Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/composed type member naming #3340

Merged
merged 10 commits into from
Sep 22, 2023
Merged

bugfix/composed type member naming #3340

merged 10 commits into from
Sep 22, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 20, 2023

fixes #3067

@baywet baywet requested a review from a team as a code owner September 20, 2023 18:20
@baywet baywet self-assigned this Sep 20, 2023
@baywet baywet enabled auto-merge September 20, 2023 18:20
@baywet baywet marked this pull request as draft September 20, 2023 19:12
auto-merge was automatically disabled September 20, 2023 19:12

Pull request was converted to draft

@baywet baywet force-pushed the bugfix/composed-type-member-naming branch from 771fbf1 to cdb013c Compare September 21, 2023 13:22
@baywet baywet marked this pull request as ready for review September 21, 2023 19:37
@baywet baywet enabled auto-merge September 21, 2023 19:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.7% 80.7% Coverage
0.0% 0.0% Duplication

baywet added a commit that referenced this pull request Sep 21, 2023
@baywet
- TODO REBASE AND DROP temporary patch for backward composed type until
206b6d2 
#3340 is merged
andrueastman
andrueastman approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 on the code cleanup (removing the IResponseHandler logic and moving IDeprecableElement to the CodeComposedTypeBase)

@baywet baywet merged commit 9b7fc49 into main Sep 22, 2023
171 checks passed
@baywet baywet deleted the bugfix/composed-type-member-naming branch September 22, 2023 09:19
@baywet baywet mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IComposedTypeWrapper has naming issues
2 participants
@baywet @andrueastman