Adds Code Files in TypeScript #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkodev
force-pushed
the
feat/ts-add-codefiles
branch
from
56cc5e9 to
154de67
Compare
rkodev
force-pushed
the
feat/ts-add-codefiles
branch
from
ffcc816 to
e682053
Compare
baywet
requested changes
Sep 19, 2023
There was a problem hiding this comment.
@rkodev CI seems to be failing, can you have a look before we review please?
Also, sorry about that, my PR about auto-generated comments was merged ahead of yours, resulting in conflicts.
We can keep most of my code changes, as the comments are only added for the elements when the parent is a code namespace (to avoid duplication). You'll only need to replicate the changes for code file as well.
baywet
requested changes
Sep 19, 2023
src/Kiota.Builder/Writers/TypeScript/CodeClassDeclarationWriter.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Builder/Writers/TypeScript/TypeScriptRelativeImportManager.cs
Outdated
Show resolved
Hide resolved
rkodev
force-pushed
the
feat/ts-add-codefiles
branch
from
c4d4fee to
727a414
Compare
src/Kiota.Builder/Writers/TypeScript/CodeFileDeclarationWriter.cs
Outdated
Show resolved
Hide resolved
baywet
requested changes
Sep 20, 2023
src/Kiota.Builder/Writers/TypeScript/CodeFileDeclarationWriter.cs
Outdated
Show resolved
Hide resolved
baywet
requested changes
Sep 20, 2023
Co-authored-by: Vincent Biret <[email protected]>
baywet
approved these changes
Sep 20, 2023
andrueastman
approved these changes
Sep 21, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2116
Adds code files that groups factories , serializers, deserializers and models into 1 file.
Sample output microsoft/kiota-samples#3644