Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- maps 4xx and 5xx to default when absent #3320

Merged
merged 2 commits into from
Sep 19, 2023
Merged

- maps 4xx and 5xx to default when absent #3320

merged 2 commits into from
Sep 19, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 18, 2023

fixes #3245

@baywet baywet requested a review from a team as a code owner September 18, 2023 19:29
@baywet baywet self-assigned this Sep 18, 2023
@baywet baywet enabled auto-merge September 18, 2023 19:29
andrueastman
andrueastman previously approved these changes Sep 19, 2023
View reviewed changes
@andrueastman andrueastman self-requested a review September 19, 2023 08:53
andrueastman
andrueastman reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baywet The intergration tests seems to fail on the branch due to an exception thrown at

kiota/src/Kiota.Builder/Writers/ProprietableBlockExtensions.cs

Line 43 in 435af59

.Select(x => new { Value = x.ReturnType is CodeType codeType && codeType.TypeDefinition is CodeClass codeClass && codeClass.GetPrimaryMessageCodePath(propertyNameNormalization, methodNameNormalization, pathSegment) is string segment && !string.IsNullOrEmpty(segment) ? $"{methodNameNormalization(x)}{pathSegment}{segment}" : string.Empty, IsMethod = true })
causing the generation to not complete

@baywet baywet force-pushed the feature/error-default branch from d710582 to bb40d51 Compare September 19, 2023 12:12
@baywet baywet force-pushed the feature/error-default branch from bb40d51 to 4debdf7 Compare September 19, 2023 12:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.2% 87.2% Coverage
0.0% 0.0% Duplication

@baywet baywet requested a review from andrueastman September 19, 2023 12:55
@baywet baywet merged commit 2b907bf into main Sep 19, 2023
171 checks passed
@baywet baywet deleted the feature/error-default branch September 19, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiota should treat Default as 4XX + 5XX
2 participants
@baywet @andrueastman