Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/x ms primary error message #3273

Merged
merged 20 commits into from
Sep 11, 2023
Merged

feature/x ms primary error message #3273

merged 20 commits into from
Sep 11, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 8, 2023

fixes #3066

baywet added 15 commits September 8, 2023 13:38
@baywet
- removes OSS test explorer from recommended extensions
f4eaf3c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- moves extensions from kiota
d085683
@baywet
- moves to facilitation method for ms extensions
3385d7d
@baywet
- adds extension mapping to property
10985e6 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds unit test for primary message property
cb3a011 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds an extension method to get the code path of the error message
e8bcec0 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds primary error message mapping in CSharp
09931cd 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds support for primary error message mapping in go
c8797e6 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- code linting
5f0143f 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- bumps Openapi.net version
9eca889
@baywet
- updates tasks configuration so it also builds test projects
78c590d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- switches error override implementations to property/method writers …
df7960f 
…in csharp and go
@baywet
- implements primary error message mapping for java
9790377 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds support for primary error message mapping in TS
03dadab 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds changelog entry for primary error mapping
3aaee6f 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet requested a review from a team as a code owner September 8, 2023 17:39
@baywet baywet self-assigned this Sep 8, 2023
@baywet baywet enabled auto-merge September 8, 2023 17:39
This was referenced Jul 23, 2024
Open
Open
Closed
Closed
@baywet baywet requested a review from andrueastman September 11, 2023 12:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

91.2% 91.2% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 3e7a05b into main Sep 11, 2023
160 of 170 checks passed
@baywet baywet deleted the feature/x-ms-primary-error-message branch September 11, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a developers, API errors should be easier to get to and get the full details
2 participants
@baywet @andrueastman