Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fixes an issue where inline response types would collide #2953

Merged
merged 12 commits into from
Sep 29, 2023
Merged

- fixes an issue where inline response types would collide #2953

merged 12 commits into from
Sep 29, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 18, 2023 •
edited
Loading

fixes #2952

@baywet baywet self-assigned this Jul 18, 2023
@sonarqubecloud

This comment was marked as outdated.

Sign in to view
@baywet baywet mentioned this pull request Jul 18, 2023
Closed
@baywet baywet force-pushed the bugfix/response-types-names branch from 9b8025f to 1c15e87 Compare September 19, 2023 17:42
@baywet baywet marked this pull request as ready for review September 21, 2023 19:37
@baywet baywet requested a review from a team as a code owner September 21, 2023 19:37
@baywet baywet marked this pull request as draft September 21, 2023 19:37
@baywet baywet force-pushed the bugfix/response-types-names branch 6 times, most recently from 3429608 to 8430caa Compare September 27, 2023 15:16
@baywet baywet marked this pull request as ready for review September 27, 2023 15:17
@baywet baywet enabled auto-merge September 27, 2023 15:17
@baywet baywet mentioned this pull request Sep 27, 2023
Merged
baywet added 11 commits September 28, 2023 14:43
@baywet
- fixes an issue where inline response types would collide
1e64d34
@baywet
- initial implementation of fallback types for conflicting inline res…
9d7f621 
…ponses

Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes the unit test for deprecation compatibility
5cb3db5
@baywet
- temp: deduplicates method, needs different name in dotnet
8994b0b
@baywet
- fixes conflicting method name for dotnet
353deab 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds missing factory method for obsolete response type
9bcb585 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes a bug where obsolete constructors would be empty in go
a2923f3 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes a bug where the obsolete constructor would have the wrong inh…
c189744 
…eritance type in go

Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds a parameter to exclude backward compatible types
d5328f9
@baywet
- adds a changelog entry for backward compatibility behaviour
27b14ba
@baywet
- removes idempotency suppression for strip
c267b2c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet force-pushed the bugfix/response-types-names branch from 09482b3 to c267b2c Compare September 28, 2023 18:43
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

79.3% 79.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@baywet baywet mentioned this pull request Sep 28, 2023
Merged
@baywet baywet merged commit 5a370c4 into main Sep 29, 2023
172 of 173 checks passed
@baywet baywet deleted the bugfix/response-types-names branch September 29, 2023 06:00
@baywet baywet mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

models for inline response schemas collide when multiple operations on the same path item
2 participants
@baywet @andrueastman