Merge pull request #3593 from microsoft/bugfix/form-data-warning

- fixes an issue where the validation rule would warn for arrays in forms

CHANGELOG.md

@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed parameters that are in camelcase to snakecase in Python. [#3525](https://github.com/microsoft/kiota/issues/3525
 - Fixed missing imports for method parameters that are query parameters.
 - Replaces the use of "new" by "override" and "virtual" in CSharp models.
+- Fixed a bug in validation rules where form data would wrongfully warn for arrays. [#3569](https://github.com/microsoft/kiota/issues/3569)
 - Fixed query parameters type mapping for arrays. [#3354](https://github.com/microsoft/kiota/issues/3354)
 - The lock file now contains the relative path to the description in case of local path. [#3151](https://github.com/microsoft/kiota/issues/3151)
 - Fixes a bug where query parameters would be missing in CSharp for ebc clients. [#3583](https://github.com/microsoft/kiota/issues/3583)

src/Kiota.Builder/Validation/UrlFormEncodedComplex.cs

@@ -25,7 +25,7 @@ private static void ValidateSchema(OpenApiSchema schema, IValidationContext cont
         if (schema == null) return;
         if (!schema.IsObject())
             context.CreateWarning(nameof(UrlFormEncodedComplex), $"The operation {operationId} has a {schemaName} which is not an object type. This is not supported by Kiota and serialization will fail.");
-        if (schema.Properties.Any(static x => x.Value.IsObject() || x.Value.IsArray()))
+        if (schema.Properties.Any(static x => x.Value.IsObject()))
             context.CreateWarning(nameof(UrlFormEncodedComplex), $"The operation {operationId} has a {schemaName} with a complex properties and the url form encoded content type. This is not supported by Kiota and serialization of complex properties will fail.");
     }
 }

tests/Kiota.Builder.Tests/Validation/UrlFormEncodedComplexTests.cs

@@ -168,6 +168,46 @@ public void DoesntAddAWarningWhenUrlEncoded()
         Assert.Empty(diag.Warnings);
     }
     [Fact]
+    public void DoesntAddAWarningOnArrayProperty()
+    {
+        var rule = new UrlFormEncodedComplex();
+        var documentTxt = @"openapi: 3.0.1
+info:
+  title: OData Service for namespace microsoft.graph
+  description: This OData service is located at https://graph.microsoft.com/v1.0
+  version: 1.0.1
+paths:
+  /enumeration:
+    post:
+      requestBody:
+        content:
+          application/x-www-form-urlencoded:
+            schema:
+              type: object
+              properties:
+                filters:
+                  type: array
+                  items:
+                    type: integer
+                    format: int32
+      responses:
+        '200':
+          content:
+            application/x-www-form-urlencoded:
+              schema:
+                type: object
+                properties:
+                  prop:
+                    type: string";
+        using var stream = new MemoryStream(Encoding.UTF8.GetBytes(documentTxt));
+        var reader = new OpenApiStreamReader(new OpenApiReaderSettings
+        {
+            RuleSet = new(new ValidationRule[] { rule }),
+        });
+        var doc = reader.Read(stream, out var diag);
+        Assert.Empty(diag.Warnings);
+    }
+    [Fact]
     public void DoesntAddAWarningWhenNotUrlEncoded()
     {
         var rule = new UrlFormEncodedComplex();