Fix VSCode's extension update (#5514)

* add kiotaVersion property to workspace json file * update workspace JSON schema * Update vscode/microsoft-kiota/src/extension.ts Co-authored-by: Faith Kangai <[email protected]> * remove kiotaVersion from workspace configuration update workspace json schema * update json schema version --------- Co-authored-by: Caleb Magiya (from Dev Box) <[email protected]> Co-authored-by: Faith Kangai <[email protected]>
microsoft · Oct 3, 2024 · a62abf6 · a62abf6
1 parent 6627a99
commit a62abf6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/specs/schemas/workspace.json b/specs/schemas/workspace.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "<http://json-schema.org/draft-07/schema#>",
+  "$schema": "https://json-schema.org/2020-12/schema",
   "type": "object",
   "properties": {
     "version": {
@@ -104,4 +104,4 @@
       }
     }
   }
-}
+}
diff --git a/vscode/microsoft-kiota/src/extension.ts b/vscode/microsoft-kiota/src/extension.ts
@@ -659,9 +659,12 @@ async function showUpgradeWarningMessage(clientPath: string, context: vscode.Ext
   }
   const workspaceFileData = await vscode.workspace.fs.readFile(vscode.Uri.file(workspaceFilePath));
   const workspaceFile = JSON.parse(workspaceFileData.toString()) as { kiotaVersion: string };
-  const clientVersion = workspaceFile.kiotaVersion.toLocaleLowerCase();
-  if (clientVersion.toLocaleLowerCase() !== kiotaVersion) {
-    await vscode.window.showWarningMessage(vscode.l10n.t("Client will be upgraded from version {0} to {1}, upgrade your dependencies", clientVersion, kiotaVersion));
+  // don't fail if kiotaVersion isn't in the workspace config file
+  if (workspaceFile.kiotaVersion) {
+    const clientVersion = workspaceFile.kiotaVersion.toLocaleLowerCase();
+    if (clientVersion !== kiotaVersion) {
+      await vscode.window.showWarningMessage(vscode.l10n.t("Client will be upgraded from version {0} to {1}, upgrade your dependencies", clientVersion, kiotaVersion));
+    }
   }
 }