Skip to content

Commit

Permalink
code review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
fey101 committed Sep 12, 2024
1 parent e74efec commit 8b5e6fe
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
14 changes: 3 additions & 11 deletions vscode/microsoft-kiota/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ You can try out the generator including your local changes by running:
dotnet run -c Release --project src/kiota/kiota.csproj -- <arguments you would pass>
```

### Debugging the Kiota Extension
See [Debugging the Extension](https://github.com/microsoft/kiota/blob/main/vscode/microsoft-kiota/debugging.md)

## Contributing Code

1. Fork the repository and clone it to your local machine.
Expand All @@ -65,17 +68,6 @@ dotnet run -c Release --project src/kiota/kiota.csproj -- <arguments you would p
4. Push your changes to your fork: `git push origin my-new-feature`
5. Create a pull request from your fork to the main repository. `gh pr create` (with the GitHub CLI)

## Troubleshooting

### Build errors

If you get build errors, particularly a message like this:
```
CSC : error CS9057: The analyzer assembly '<path>/KiotaGenerated.dll' references version '4.5.0.0' of the compiler, which is newer than the currently running version '4.4.0.0'.
```

try updating your .NET SDK to the latest version.

## Reporting Bugs

If you find a bug in Kiota, please report it by opening a new issue in the issue tracker. Please include as much detail as possible, including steps to reproduce the bug and any relevant error messages.
Expand Down
2 changes: 1 addition & 1 deletion vscode/microsoft-kiota/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Check out our [SECURITY.md](https://github.com/microsoft/kiota/blob/main/SECURIT

## Telemetry

Kiota collects usage data and sends it to Microsoft to help improve our products and services. Read our [Privacy Statement](https://go.microsoft.com/fwlink/?LinkId=521839) and [Data Collection Notice](https://docs.opensource.microsoft.com/content/releasing/telemetry.html) to learn more. Learn more in our [FAQ](https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-telemetry-reporting).
Kiota Core and Kiota extension collects usage data and sends it to Microsoft to help improve our products and services. Read our [Privacy Statement](https://go.microsoft.com/fwlink/?LinkId=521839) and [Data Collection Notice](https://docs.opensource.microsoft.com/content/releasing/telemetry.html) to learn more. Learn more in our [FAQ](https://code.visualstudio.com/docs/supporting/faq#_how-to-disable-telemetry-reporting).

## Trademarks

Expand Down
Binary file removed vscode/microsoft-kiota/images/kiotalogo.png
Binary file not shown.
2 changes: 1 addition & 1 deletion vscode/microsoft-kiota/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"version": "1.18.100000001",
"kiotaVersion": "1.18.0",
"telemetryInstrumentationKey": "4c6357e0-daf9-42b5-bdfb-67878f8957b5",
"icon": "images/kiotalogo.png",
"icon": "images/logo.png",
"engines": {
"vscode": "^1.93.0"
},
Expand Down

0 comments on commit 8b5e6fe

Please sign in to comment.