Skip to content

Commit

Permalink
Add CHANGELOG entry
Browse files Browse the repository at this point in the history
  • Loading branch information
Ndiritu committed Oct 5, 2023
1 parent e6b3c84 commit 28b8860
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Log a message to stderr if a request is skipped due to missing data. (CLI) [#2210](https://github.com/microsoft/kiota/issues/2210)
- Fixes code file generation in typescript [#3419](https://github.com/microsoft/kiota/issues/3419)
- Writes fully qualified name of custom types when a type with a similar name exists in the class in PHP.
- Rename composed type wrapper when class already exists in the namespace. [#2964](https://github.com/microsoft/kiota/issues/2964)

## [1.6.1] - 2023-09-11

Expand Down
8 changes: 4 additions & 4 deletions tests/Kiota.Builder.Tests/Refiners/PhpLanguageRefinerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -249,16 +249,16 @@ public async Task RenamesComposedTypeWrapperWhenSimilarClassExistsInNamespace()
Name = "Parent"
};
root.AddClass(model, parent);

var composedType = new CodeUnionType { Name = "Union" };
composedType.AddType(new CodeType { Name = "string" }, new CodeType { Name = "int"});
composedType.AddType(new CodeType { Name = "string" }, new CodeType { Name = "int" });

var composedProperty = parent.AddProperty(new CodeProperty
{
Name = "property",
Type = composedType
}).First();

await ILanguageRefiner.Refine(new GenerationConfiguration { Language = GenerationLanguage.PHP }, root);
Assert.NotNull(root.FindChildByName<CodeClass>("UnionWrapper", false));
}
Expand Down

0 comments on commit 28b8860

Please sign in to comment.