Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Implements IAsyncParseNodeFactory interface #220

Merged
merged 7 commits into from
May 9, 2024
Merged

Implements IAsyncParseNodeFactory interface #220

merged 7 commits into from
May 9, 2024

Conversation

MihaMarkic
Copy link
Contributor

Adds async support and marks sync method obsolete

baywet
baywet suggested changes May 3, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! a minor recommendation

src/JsonParseNodeFactory.cs Show resolved Hide resolved
andrueastman
andrueastman previously approved these changes May 7, 2024
View reviewed changes
baywet
baywet previously approved these changes May 7, 2024
View reviewed changes
@baywet baywet marked this pull request as ready for review May 7, 2024 11:54
@baywet baywet requested a review from a team as a code owner May 7, 2024 11:54
@baywet
Copy link
Member

baywet commented May 7, 2024

@MihaMarkic is this good to merge from your perspective?

@baywet baywet dismissed stale reviews from andrueastman and themself via 2025083 May 8, 2024 14:45
@MihaMarkic
Copy link
Contributor Author

@baywet Yep

@andrueastman andrueastman merged commit c7284b0 into microsoft:main May 9, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MihaMarkic @baywet @andrueastman