-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/outdated deps #391
fix/outdated deps #391
Conversation
baywet
commented
Oct 16, 2024
- fix: version requirement for httpx
- fix: dependabot configuration for new project structure
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Quality Gate passedIssues Measures |
I believe there's a conflict with #387 |
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
@andrueastman yes, I believe we identified the problem at about the same time. We have a bunch of outdated dependencies in the toml files. (not sure whether it's a regression, old repos used the requirements file) Also from looking at the dependabot documentation |
Just checking in here. Any chance this is still an issue after the dependabot PRs? I believe dependabot should be able to handle the poetry deps. as it is listed in below. I believe the discrepancy was caused by incorectly pulling the version range modifiers from the original projects (using |
I wasn't sure why we were not getting any dependabot PRs on the toml. I thought it was because of the file "format" but now that we've received a PR I think here is what happened:
If this is your understanding as well. I don't think we need to take further action at this point, At least not for the dependabot aspects. Maybe we'll want to mordernize our toml files for other reasons, but nothing pressing as far as I can tell. |