Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/initialize default headers #170

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Chore/initialize default headers #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91c85d5
Initialize headers in base request configuration to a headerscollecti…
samwelkanda Oct 25, 2023
8814621
Bump version and add CHANGELOG entry
samwelkanda Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.9.1] - 2023-10-25

### Added

### Changed
- Initialize headers in BaseRequestConfiguration to a HeadersCollection instance

## [0.9.0] - 2023-10-10

### Added
Expand Down
2 changes: 1 addition & 1 deletion kiota_abstractions/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION: str = "0.9.0"
VERSION: str = "0.9.1"
3 changes: 2 additions & 1 deletion kiota_abstractions/base_request_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from dataclasses import dataclass
from typing import Dict, List, Optional, Union

from .headers_collection import HeadersCollection
from .request_option import RequestOption


Expand All @@ -15,7 +16,7 @@ class BaseRequestConfiguration:
Configuration for the request such as headers, query parameters, and middleware options.
"""
# Request headers
headers: Optional[Dict[str, Union[str, List[str]]]] = None
headers: HeadersCollection = HeadersCollection()

# Request options
options: Optional[List[RequestOption]] = None