Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/refactor request headers #162

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Chore/refactor request headers #162

merged 13 commits into from
Oct 18, 2023

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Oct 17, 2023 •
edited by baywet
Loading

Adds a dedicated RequestHeaders class to handle headers

Related to microsoft/kiota#3430

closes #158

@samwelkanda samwelkanda marked this pull request as ready for review October 17, 2023 06:06
baywet
baywet reviewed Oct 17, 2023
View reviewed changes
kiota_abstractions/request_information.py Outdated Show resolved Hide resolved
kiota_abstractions/request_headers.py Outdated Show resolved Hide resolved
kiota_abstractions/request_headers.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samwelkanda samwelkanda requested a review from baywet October 18, 2023 11:28
baywet
baywet approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@samwelkanda samwelkanda merged commit 7917522 into main Oct 18, 2023
12 checks passed
@samwelkanda samwelkanda deleted the chore/refactor-request-headers branch October 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@andrueastman andrueastman Awaiting requested review from andrueastman

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwelkanda @baywet