Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a try_add method for request headers #155

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Oct 4, 2023

Preparation work for: microsoft/kiota#3401

SilasKenneth
SilasKenneth previously approved these changes Oct 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@baywet
Copy link
Member

baywet commented Oct 5, 2023

Thanks for the work here @samwelkanda for release
Also this made me realize the Python implementation is not aligned with other languages so I created this issue.
microsoft/kiota#3430

@andreaTP
Copy link
Contributor Author

If we can get this one merged I can proceed with the final implementation in Kiota without risk of breaking 🙏

@baywet baywet merged commit af5ad23 into microsoft:main Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants