Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Std.UriTemplate lib to 0.54 and add a unit test. #205

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Mar 7, 2024

Upgrade the Std.UriTemplate lib to 0.54 and add a unit test.

Related to observed behavior here: std-uritemplate/std-uritemplate#114

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's strange that dependabot didn't pick it up for us...
Can you also bump the patch and add a changelog entry (tomorrow, changed) so we can expedite the release please?

@andrueastman
Copy link
Member

Just to confirm, dependabot updated the dependency via #203. We just need to release a new update to abstractions with the new dependency.
@IEvangelist Any chance you can make sure you rebase/sync your branch as well?

@IEvangelist IEvangelist force-pushed the upgrade-std-and-test branch from b35dbe6 to 936d415 Compare March 8, 2024 15:55
@IEvangelist
Copy link
Member Author

Done

baywet
baywet previously requested changes Mar 8, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lost the version bump in the csproj somehow

@andrueastman andrueastman enabled auto-merge March 11, 2024 06:42
@andrueastman andrueastman dismissed baywet’s stale review March 11, 2024 06:50

Version is csproj is bumped now.

@andrueastman andrueastman merged commit 2cf0233 into microsoft:main Mar 11, 2024
7 checks passed
@IEvangelist
Copy link
Member Author

IEvangelist commented Mar 19, 2024

Tip

Tagging @nickfloyd, you're going to want to upgrade to whatever version this ships in for the Ocokit .NET SDK. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants