Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand arrays when dealing with parameters in RequestInformation #158

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

Nex-Code
Copy link

Fix for microsoft/kiota#3354

Objects with an array type need to be expanded and converted to strings otherwise Std.UriTemplate attempts to cast them to strings and fails later.

@Nex-Code
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Can you:

  1. bump the patch version in the csproj
  2. add an entry in the changelog (new section for the version, today's date, changed section)
    Thanks!

Added change log
@Nex-Code Nex-Code requested a review from baywet November 30, 2023 13:53
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. @andrueastman for review and merge

@andrueastman andrueastman merged commit 8a85664 into microsoft:main Dec 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants