Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TryAdd when setting Content-Type #132

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Use TryAdd when setting Content-Type #132

merged 2 commits into from
Oct 5, 2023

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Oct 4, 2023

Forgot to actually use TryAdd ...

andrueastman
andrueastman reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add a version bump and changelog entry as well to release?
Otherwise, looks good to me 👍🏼

@andreaTP
Copy link
Contributor Author

andreaTP commented Oct 4, 2023

Any chance you can add a version bump and changelog entry as well to release?

I can, but I thought what I have added yesterday is already enough, let me know if I should do it anyhow!

@andrueastman
Copy link
Member

I think we should just do it. I believe the interaction with the SetStreamContent and other methods would be incongruent with what we are trying to achieve at microsoft/kiota#3378 if we don't release the change.

baywet
baywet requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we'll need a new release since the other one was published

@andreaTP
Copy link
Contributor Author

andreaTP commented Oct 5, 2023

It's a holiday today, I'll make the changes tomorrow 👍

baywet
baywet previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreaTP no worries, enjoy your time off, I've just pushed the changes

@baywet baywet enabled auto-merge October 5, 2023 14:26
@baywet baywet merged commit ea0782a into microsoft:main Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaTP @andrueastman @baywet