Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Hotfix HTTP error downloading model with hub #552

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Aug 4, 2022

Specifying the branch when downloading a model using PyTorch Hub shouldn't be necessary, but an HTTP error was being raised anyway. There seem to have been issues with this in the past:

Explicitly specifying main seems to help, so I'm adding it to the test, and it should be included in any future documentation, just in case.

@fepegar fepegar added bug Something isn't working tooling and CI Improvements to linting, CI workflows, IDE hi-ml-multimodal Issues related to the hi-ml-multimodal package labels Aug 4, 2022
@fepegar fepegar enabled auto-merge (squash) August 4, 2022 10:51
@Shruthi42
Copy link
Contributor

Shruthi42 commented Aug 4, 2022

Do we know how torch hub recommends versioning models? Do they recommend always pointing to main or to a specific release, for example?

@fepegar
Copy link
Contributor Author

fepegar commented Aug 4, 2022

Thanks. No recommendations, really. Just possibilities. This is all they have:

github - a string with format “repo_owner/repo_name[:ref]” with an optional ref (tag or branch). If ref is not specified, the default branch is assumed to be main if it exists, and otherwise master. Example: ‘pytorch/vision:0.10’

In future docs, we can ask mention that tags should be specified for specific versions. But this is not trivial in a multi-package repo...

@fepegar fepegar disabled auto-merge August 4, 2022 15:45
@fepegar fepegar merged commit dbca94c into main Aug 4, 2022
@fepegar fepegar deleted the hotfix-hub branch August 4, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hi-ml-multimodal Issues related to the hi-ml-multimodal package tooling and CI Improvements to linting, CI workflows, IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants