fix: avoid empty CSS imports #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 1289343d950319f48888cfe70c1c84af066f08db |
ling1726
reviewed
Dec 9, 2022
| @@ -0,0 +1 @@ | |||
| export const foo = '__styles'; | |||
There was a problem hiding this comment.
wouldn't it make more sense to have better regex ? like __styles()? 🤔
There was a problem hiding this comment.
Yes, but this loader targets node_modules and needs to process thousands files in real projects, so if will put a regex in the hot path I believe that it will be a bottleneck.
There was a problem hiding this comment.
perhaps some kind of sliding window algorithm might be able to do the same thing while still being faster than Regex, especially you know how the call starts and terminates 🤔
but I guess handling empty buckets is a better gate
ling1726
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266. More details in #266 (comment).
Our Babel plugin that strips runtime also returns a set of CSS rules in its metadata. Before this PR it always returned at least an empty object. Because of this the check below didn't work:
griffel/packages/webpack-extraction-plugin/src/webpackLoader.ts
Line 68 in 1289343
As the check was passing always we were creating invalid imports for files that contain
__stylesas a string. Files like that were processed => got empty set of CSS rules => created an invalid import => crashed build.