feat(react-keytips): add support for shortcuts #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
feat/keytips-support-for-persisted
branch
from
1e9b3c5 to
d9ac622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature aims to provide support for previously available 'persisted' keytips in v8. In v8, the OverflowSet was responsible for registering persisted keytips inside.
Current implementation offers
useMenuShortcuthook, which in addition to created useKeytipRefs inside of each menu, will create aliases under the root, which can be invoked from the top level. It will open all sub menus and reach the targeted keytip and execute it's callback.The documentation and tests will be added as follow up to this PR.