chore(react-keytips): add themes addon #238
Conversation
mainframev
requested review from
a team,
dmytrokirpa,
spmonahan and
marcosmoura
as code owners
| @@ -52,6 +52,7 @@ | |||
| "@storybook/addon-essentials": "7.6.10", | |||
| "@storybook/addon-interactions": "^7.5.3", | |||
| "@storybook/addon-storysource": "7.6.10", | |||
| "@storybook/addon-themes": "7.6.17", | |||
There was a problem hiding this comment.
all sb versions needs to be on same version - please bump other packages as well
| @@ -4,6 +4,9 @@ const config: StorybookConfig = { | |||
| stories: ['../stories/**/index.stories.@(js|jsx|ts|tsx|mdx)'], | |||
| addons: [ | |||
| '@nx/react/plugins/storybook', | |||
| '@storybook/addon-docs', | |||
There was a problem hiding this comment.
seems this adds more than "advertised" within the PR 👀
- why do we need actions ? is anyone using that ( from my personal experiences using those might be an anti-pattern )
- what about the docs addon ?
| <Story /> | ||
| </FluentProvider> | ||
| ), | ||
| withThemeFromJSXProvider({ |
There was a problem hiding this comment.
this starts to become a maintenance burden / hard to manage boilerplate - this should be implemented as part of sb plugin ( we have this in core repo AFAIR ? -> it will be published and streamlined here as well in future )
I'd start just with adding this functionality to your package in order to not introduce unmaintained boilerplate while accommodating your package needs. wdyt?
There was a problem hiding this comment.
I thought about this as well, but after noticed it's not published and was't sure if it's planned to be published, decided to use this approach as for contrib that might be sufficient to use official sb plugin for theming. Will close this one then. Thanks.
packages/pierce-dom/.eslintrc.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "extends": ["../../.eslintrc.json"], | |||
| "ignorePatterns": ["!**/*"], | |||
| "ignorePatterns": ["!**/*", "storybook-static"], | |||
There was a problem hiding this comment.
was added automatically when I run generator, will check why it was added
mainframev
force-pushed
the
docs/add-sb-addon
branch
from
ec20ebb to
cb8e4f3
Compare
mainframev
changed the title
Hotell
changed the title
mainframev
force-pushed
the
docs/add-sb-addon
branch
from
cb8e4f3 to
162ff39
Compare
adding themes addon for upcoming #221