-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-interactive-tab): InteractiveTab component initial implementation #217
feat(react-interactive-tab): InteractiveTab component initial implementation #217
Conversation
1fb8737
to
c32f625
Compare
61d2102
to
1c5bc1c
Compare
packages/react-interactive-tab/src/components/InteractiveTab/InteractiveTab.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-interactive-tab/src/components/InteractiveTab/renderInteractiveTab.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments. ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait on folks guidance with the jsx custom pragma setup
packages/react-interactive-tab/stories/InteractiveTab/index.stories.tsx
Outdated
Show resolved
Hide resolved
b1a24e1
to
dcd7cf6
Compare
packages/react-interactive-tab/src/components/InteractiveTab/renderInteractiveTab.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 actionable - for the jsx pragma
ty
636c214
to
ccfb788
Compare
Context
Previously, TabList was unable to support interactive tabs, such as tabs with a dismiss/close button to remove them, or tabs that included a dropdown or search box.
The primary slot for a Tab was a button designated with role=tab. Per ARIA guidelines, elements with role=tab are expected to only contain presentational children.
New Behavior
This PR introduces the InteractiveTab component, which is an extension of
Tab
, utilizing a div as its base. It features three additional slots: button (whererole=tab
is applied),beforeContent
, andafterContent
. This structure, reminiscent of theInput
component, permits the insertion of interactive elements both before and after the tab button.The
InteractiveTab
applies indicator styles to the root div and button styles to thebutton
slot.Related Issue(s)
Blocked by microsoft/fluentui#32125
Addresses issue #32078