fix(resize-handle): make ref callback stable #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Aug 14, 2024
| @@ -48,7 +48,7 @@ export type UseResizeHandleParams = { | |||
| * A function that will be called to get the value that will be set as the aria-valuetext attribute on the resize handle. | |||
| * Use this for localization. | |||
| */ | |||
| getA11ValueText?: (value: number) => string; | |||
| getA11ValueText?: (value: number) => string | undefined; | |||
There was a problem hiding this comment.
This actually allows undefined, the default impl also returns undefined.
layershifter
commented
Aug 14, 2024
Comment on lines
+84
to
+88
| const handleChange: UseResizeHandleParams['onChange'] = useEventCallback( | ||
| (value) => { | ||
| onChange?.(value); | ||
| } | ||
| ); |
There was a problem hiding this comment.
We need to use useEventCallback() callback there, otherwise we make memoization an implicit contract
layershifter
commented
Aug 14, 2024
| @@ -68,8 +72,7 @@ export const useResizeHandle = (params: UseResizeHandleParams) => { | |||
| onChange, | |||
| onDragStart, | |||
| onDragEnd, | |||
| getA11ValueText = (value) => | |||
| value === UNMEASURED ? undefined : `${value.toFixed(0)}px`, | |||
| getA11ValueText = DEFAULT_GET_A11_VALUE_TEXT, | |||
There was a problem hiding this comment.
getA11ValueText before was unstable reference
george-cz
approved these changes
Aug 14, 2024
george-cz
added a commit
that referenced
this pull request
Aug 19, 2024
This reverts commit 09e0824.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments on code.