BREAKING: remove "tabIndex" assigned to handle by default #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealkhou
force-pushed
the
users/fealkhou/react-resize-handle/fix-tab-index
branch
3 times, most recently
from
542c3ed to
c0ae713
Compare
|
@microsoft-github-policy-service agree |
fealkhou
force-pushed
the
users/fealkhou/react-resize-handle/fix-tab-index
branch
from
0ab6219 to
3f26672
Compare
fealkhou
force-pushed
the
users/fealkhou/react-resize-handle/fix-tab-index
branch
from
ca60ddc to
31a551a
Compare
layershifter
changed the title
george-cz
approved these changes
Aug 16, 2024
layershifter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This is a breaking change, so if you got here after debugging an issue with focus on the handle and just want to fix your issue quickly, just know that you should now pass
tabIndex={0}to your handle element to make it focusable.More context
This change removes the default
tabIndex=0attribute from the set that is being passed to the handle after an update.This means that by default the handle will not be set focusable and you have to manually add
tabIndex={0}prop to your handle element.This change was introduced after the conclusion internally that maybe not every use case requires the handle to be focusable right away and this feature should be controlled from the user, which was not possible before. Since this is still major version 0 and pretty much still in active development, any API changes like this should be expected.