fixup! feat(react-keytips): draft implementation

microsoft · Sep 2, 2024 · 129cb22 · 129cb22
1 parent 2d2a960
commit 129cb22
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/packages/react-keytips/src/components/Keytip/Keytip.types.ts b/packages/react-keytips/src/components/Keytip/Keytip.types.ts
@@ -16,17 +16,19 @@ export type KeytipSlots = {
   content: NonNullable<Slot<'div'>>;
 };
 
-export type ExecuteKeytipEventHandler<E = HTMLElement> = EventHandler<
-  EventData<'keydown', KeyboardEvent> & {
-    targetElement: E;
-  }
->;
+export type ExecuteKeytipEventHandler<E = PositioningProps['target']> =
+  EventHandler<
+    EventData<'keydown', KeyboardEvent> & {
+      targetElement: E;
+    }
+  >;
 
-export type ReturnKeytipEventHandler<E = HTMLElement> = EventHandler<
-  EventData<'keydown', KeyboardEvent> & {
-    targetElement: E;
-  }
->;
+export type ReturnKeytipEventHandler<E = PositioningProps['target']> =
+  EventHandler<
+    EventData<'keydown', KeyboardEvent> & {
+      targetElement: E;
+    }
+  >;
 
 export type OnVisibleChangeData = {
   visible: boolean;

diff --git a/packages/react-keytips/src/hooks/useTree.ts b/packages/react-keytips/src/hooks/useTree.ts
@@ -3,14 +3,15 @@ import * as React from 'react';
 import { sequencesToID, createNode } from '../utilities';
 import { KTP_ROOT_ID } from '../constants';
 import { useFluent } from '@fluentui/react-components';
+import { PositioningProps } from '@fluentui/react-components';
 
 export type KeytipTreeNode = Pick<
   KeytipProps,
   'keySequences' | 'onExecute' | 'onReturn' | 'dynamic'
 > & {
   id: string;
   uniqueId: string;
-  target: HTMLElement | null;
+  target: PositioningProps['target'];
   parent: string;
   children: Set<string>;
 };