update min r version to 4.0 to comply with tune pkg

microsoft · Apr 24, 2024 · f214e9e · f214e9e
1 parent 9da5a2c
commit f214e9e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -32,7 +32,7 @@ jobs:
           - {os: ubuntu-20.04,   r: 'release'}
           - {os: ubuntu-20.04,   r: 'oldrel-1'}
           - {os: ubuntu-20.04,   r: 'oldrel-2'}
-          - {os: ubuntu-20.04,   r: '3.6'} #3.6 is the min version for finnts
+          - {os: ubuntu-20.04,   r: '4.0'} # 4.0 is the min version for finnts
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -78,6 +78,6 @@ Suggests:
     vip
 Config/testthat/edition: 3
 Depends: 
-    R (>= 3.6.0), 
+    R (>= 4.0), 
     modeltime
 VignetteBuilder: knitr
diff --git a/NEWS.md b/NEWS.md
@@ -10,6 +10,10 @@
 -   Error in run_type column join in final forecast output
 -   Error in running feature selection
 
+## Breaking Changes
+
+-   Minimum R version now set to R 4.0 to comply with package dependency minimum version for tune
+
 # finnts 0.4.0
 
 ## Improvements

diff --git a/tests/testthat/test-hierarchical.R b/tests/testthat/test-hierarchical.R
@@ -1,6 +1,5 @@
 
 test_that("prep_hierarchical_data returns correct grouped hierarchies", {
-  skip_if(getRversion() < "3.7.0", "Skipping for R 3.6.0 and below")
 
   # Mock data setup
   data <- tibble::tibble(
@@ -78,7 +77,6 @@ test_that("prep_hierarchical_data returns correct grouped hierarchies", {
 })
 
 test_that("prep_hierarchical_data returns correct standard hierarchies", {
-  skip_if(getRversion() < "3.7.0", "Skipping for R 3.6.0 and below")
 
   # Mock data setup
   data <- tibble::tibble(