Merge pull request #151 from microsoft/mitokic/07022024/missing-colum…

…n-fix Fixed bug of having run_type duplicated when joining dataframes
microsoft · Feb 21, 2024 · 6681122 · 6681122
2 parents dd64b38 + 344dbc0
commit 6681122
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: finnts
 Title: Microsoft Finance Time Series Forecasting Framework
-Version: 0.4.0
+Version: 0.4.0.9000
 Authors@R: 
     c(person(given = "Mike",
            family = "Tokic",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# finnts 0.4.0.9000 (DEVELOPMENT VERSION)
+
+## Bug Fixes
+
+-   Error in run_type column join in final forecast output
+
 # finnts 0.4.0
 
 ## Improvements

diff --git a/R/ensemble_models.R b/R/ensemble_models.R
@@ -404,10 +404,6 @@ ensemble_models <- function(run_info,
             Train_Test_ID = id
           ) %>%
           dplyr::mutate(Train_Test_ID = as.numeric(Train_Test_ID)) %>%
-          dplyr::left_join(model_train_test_tbl %>%
-            dplyr::select(Run_Type, Train_Test_ID),
-          by = "Train_Test_ID"
-          ) %>%
           dplyr::left_join(
             prep_ensemble_tbl %>%
               dplyr::mutate(.row = dplyr::row_number()) %>%

diff --git a/R/train_models.R b/R/train_models.R
@@ -510,10 +510,6 @@ train_models <- function(run_info,
             Train_Test_ID = id
           ) %>%
           dplyr::mutate(Train_Test_ID = as.numeric(Train_Test_ID)) %>%
-          dplyr::left_join(model_train_test_tbl %>%
-            dplyr::select(Run_Type, Train_Test_ID),
-          by = "Train_Test_ID"
-          ) %>%
           dplyr::left_join(
             prep_data %>%
               dplyr::mutate(.row = dplyr::row_number()) %>%