Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] 1.7 #230 [bug] disable --limit on show (again) #236

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[backport] 1.7 #230 [bug] disable --limit on show (again) #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions dbt/include/synapse/macros/adapters/show.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
{% macro get_show_sql(compiled_code, sql_header, limit) -%}
{%- if sql_header -%}
{{ sql_header }}
{%- endif -%}
{%- if limit is not none -%}
{%- set warn = "--limit is ignored. Synapse doesn't support the implementation" -%}
{{ log(warn, info=True) }}
{%- endif -%}
{{ compiled_code }}

{% endmacro %}

{% macro get_limit_subquery_sql(sql, limit) %}
{{ adapter.dispatch('get_limit_subquery_sql', 'dbt')(sql, limit) }}
{% endmacro %}

{# Synapse doesnt support ANSI LIMIT clause #}
{% macro synapse__get_limit_subquery_sql(sql, limit) %}
select top {{ limit }} *
from (
{{ sql }}
) as model_limit_subq
{%- set warn = "-- limit of " ~ limit ~ " is ignored. Synapse doesn't support the implementation" -%}

{{ warn }}
{{ sql }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dataders , I just realized that the sql will select entire data in the table. What's the downside of leaving the query as

select top {{ limit }} * from ( {{ sql }} ) as model_limit_subq

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check out #228 basically comes down to lack of support for nested CTEs again! sql can't contain a WITH or it breaks


{% endmacro %}
5 changes: 3 additions & 2 deletions tests/functional/adapter/test_dbt_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,6 @@ class TestShowSqlHeaderSynapse(BaseShowSqlHeader):
pass


class TestShowLimitSynapse(BaseShowLimit):
pass
# Disabled because dbt-synapse doesn't support the `--limit` flag
# class TestShowLimitSynapse(BaseShowLimit):
# pass