Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0rc #192

Closed
wants to merge 47 commits into from
Closed

v1.5.0rc #192

wants to merge 47 commits into from

Conversation

nszoni
Copy link
Contributor

@nszoni nszoni commented Feb 13, 2024

Support for dbt-core 1.5

  • Add support for model contracts by adapting create_table_as and create_view_as macros
  • Define supported constraints in CONSTRAINT_SUPPORT Adapter class.
  • Persist docs via extended properties is not supported in Synapse
  • Add adapter tests zones
    • caching
    • column_types
    • constraints
    • hooks
    • simple_copy
    • dbt_show

base branch from #191

arthurcht and others added 30 commits February 2, 2024 17:43
…d in 'CREATE TABLE AS SELECT'..." error - switch dependency
… in use...duplicate...not permitted" - switch dependency
…ion" macro in relation.sql updated - switch dependency
…cro that does not specify Distribution option in "CREATE TABLE AS SELECT" - switch dependency
…k to dependency switch discussion in CHANGELOG.md - switch dependency
…o "synapse__create_schema_with_authorization", fixed failing test_schema.py by adding "schema_authorization" variable to dbt_profile
…arootsio/dbt-synapse-dataroots into dbtsynapse1.5
@nszoni
Copy link
Contributor Author

nszoni commented Feb 13, 2024

@nszoni please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="dataroots"

from dbt.tests.util import check_relations_equal, run_dbt


def dbt_profile_target(request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nszoni are lines 19-27 needed? seems the same (nothing overwritten) as in tests/conftest.py?
besides no pytest.fixture(scope="class") and no raise ValueError...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 🥇

@nszoni nszoni marked this pull request as ready for review February 14, 2024 11:15
@nszoni nszoni closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants