alert to remove pyodbc from dev_requirements.txt, if using Windows

microsoft · Feb 12, 2024 · 7fadfff · 7fadfff
1 parent a46b586
commit 7fadfff
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 
 #### Under the hood
 * Switch dependency from dbt-sqlserver to dbt-fabric (per https://github.com/dbt-msft/dbt-sqlserver/issues/441)
+  * if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt
 
 ## v1.4.0
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -16,7 +16,7 @@ pyenv activate dbt-synapse
 Install the development dependencies and pre-commit and get information about possible make commands:
 
 ```shell
-make dev
+make dev  # if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt
 make help
 ```
 

diff --git a/dev_requirements.txt b/dev_requirements.txt
@@ -5,7 +5,7 @@ pre-commit==2.21.0;python_version<"3.8"
 pre-commit==3.3.1;python_version>="3.8"
 pytest-dotenv==0.5.2
 dbt-tests-adapter~=1.4.9
-pyodbc==4.0.39 --no-binary :all:
+pyodbc==4.0.39 --no-binary :all:  # if Windows, remove
 aiohttp==3.8.3
 azure-mgmt-synapse==2.0.0
 flaky==3.7.0