Ensure Testview Name Uniqueness with MD5 of Model Name and Invocation ID #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Every dbt test creates a view with the name "testview_<random_number>". If a test can not be executed, maybe because a column name is wrong, the view doesn't get dropped afterwards.
The next iteration might want to create a view with the same name, because the range of the random funtion is quite limited. It can't create that, because the name is already taken (if you are unlucky). This leads to an error.
Solution
Instead of using a random function, I used
testview_{{ local_md5(model.name ~ invocation_id) }}
. Not using MD5 would be nicer for readability, but you might run into issues regarding the maximum object name length of 128 characters.