Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depencency for dbt-common #142

Closed
wants to merge 1 commit into from

Conversation

ChenyuLInx
Copy link
Contributor

No description provided.

@amychen1776
Copy link

@prdpsvs can you assist on this? It's a blocker for us to support versionless.

@prdpsvs
Copy link
Collaborator

prdpsvs commented Mar 14, 2024

@amychen1776 , There seems to be additional permissions to be given on the pipeline. I am looking into additional permissions. For now, @ChenyuLInx , please do not fork and create a local branch and create a pull request?

@ChenyuLInx
Copy link
Contributor Author

@prdpsvs I don't think I can do that since I am an outside contributor, do you mind just do this change and do an 1.8 rc release?

@ChenyuLInx
Copy link
Contributor Author

@prdpsvs bumping this again for visibility. It might be easier if you can just make the change and release a new RC version. Thanks!!!!

@prdpsvs
Copy link
Collaborator

prdpsvs commented Mar 19, 2024

@ChenyuLInx , https://github.com/microsoft/dbt-fabric/invitations
I sent you an invitation. You have permissions to create a PR on this repo. Do let me know as soon as your change is available. I will approve.
I am busy with other priorities and unfortunately cannot open PR until day after tomorrow.

@ChenyuLInx
Copy link
Contributor Author

@prdpsvs Thanks for the update!
I tried to clone and push a branch to this repo from local and got

ERROR: Permission to microsoft/dbt-fabric.git denied to ChenyuLInx.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

And Tried to create another PR here, looks like checks are failing the same way

@prdpsvs
Copy link
Collaborator

prdpsvs commented Mar 26, 2024

@ChenyuLInx I have merged the other PR. Please use that. I will abandon this PR and close this one.

@prdpsvs prdpsvs closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants