Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support net 8 #492

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
"isRoot": true,
"tools": {
"dotnet-counters": {
"version": "6.0.351802",
"version": "8.0.452401",
"commands": [
"dotnet-counters"
]
},
"dotnet-dump": {
"version": "6.0.351802",
"version": "8.0.452401",
"commands": [
"dotnet-dump"
]
},
"dotnet-ilverify": {
"version": "7.0.0",
"version": "8.0.0",
"commands": [
"ilverify"
]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
uses: NuGet/setup-nuget@v1
with:
nuget-version: '6.x'
- name: Setup .NET 7.0 SDK
- name: Setup .NET 8.0 SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: '7.0.x'
dotnet-version: '8.0.x'
- name: Set environment variables
run: echo "COYOTE_CLI_TELEMETRY_OPTOUT=1" >> $GITHUB_ENV
# Initializes the CodeQL tools for scanning.
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/test-coyote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,19 @@ jobs:
env:
COYOTE_CLI_TELEMETRY_OPTOUT: 1
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Setup NuGet.exe
uses: NuGet/setup-nuget@v1
with:
nuget-version: '6.x'
- name: Setup .NET 7.0 SDK
uses: actions/setup-dotnet@v1
- name: Setup .NET SDK
uses: actions/setup-dotnet@v3
with:
dotnet-version: '7.0.x'
- name: Setup .NET 6.0 SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: '6.0.x'
- name: Setup .NET Core 3.1 SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: '3.1.x'
dotnet-version: |
3.1.x
6.0.x
7.0.x
8.0.x
- name: Setup debugging tools
if: ${{ matrix.platform == 'windows-latest' }}
run: |
Expand Down Expand Up @@ -80,11 +76,15 @@ jobs:
env:
COYOTE_CLI_TELEMETRY_OPTOUT: 1
steps:
- uses: actions/checkout@v2
- name: Setup .NET 7.0 SDK
uses: actions/setup-dotnet@v1
- uses: actions/checkout@v4
- name: Setup .NET SDK
uses: actions/setup-dotnet@v3
with:
dotnet-version: '7.0.x'
dotnet-version: |
3.1.x
6.0.x
7.0.x
8.0.x
- name: Download Coyote binaries
uses: actions/download-artifact@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
uses: NuGet/setup-nuget@v1
with:
nuget-version: '6.x'
- name: Setup .NET 7.0 SDK
- name: Setup .NET 8.0 SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: '7.0.x'
dotnet-version: '8.0.x'
- name: Setup Powershell
run: ./Scripts/install-pwsh.cmd
- name: Build Coyote projects
Expand Down
14 changes: 12 additions & 2 deletions Common/build.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<RepositoryUrl>https://github.com/microsoft/coyote</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<!-- Add this since netcoreapp3.1 is out of support https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1138 -->
<CheckEolTargetFramework>false</CheckEolTargetFramework>
</PropertyGroup>
<PropertyGroup>
<PackageProjectUrl>https://microsoft.github.io/coyote/</PackageProjectUrl>
Expand All @@ -16,10 +18,13 @@
<PackageLicenseFile>LICENSE</PackageLicenseFile>
<PackageOutputPath>$(MSBuildThisFileDirectory)/../bin/nuget</PackageOutputPath>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
<LangVersion>12.0</LangVersion>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'net7.0' or '$(TargetFramework)' == 'net6.0'">
<LangVersion>10.0</LangVersion>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' != 'net7.0' and '$(TargetFramework)' != 'net6.0'">
<PropertyGroup Condition="'$(TargetFramework)' != 'net8.0' and '$(TargetFramework)' != 'net7.0' and '$(TargetFramework)' != 'net6.0'">
<LangVersion>8.0</LangVersion>
</PropertyGroup>
<PropertyGroup>
Expand Down Expand Up @@ -48,10 +53,15 @@
<Net6Installed>false</Net6Installed>
<Net6Installed Condition="$(GlobalVersion.StartsWith('6.0'))">true</Net6Installed>
<Net6Installed Condition="'$(BUILD_NET6)'=='yes'">true</Net6Installed>
<TargetFrameworks>net7.0</TargetFrameworks>
<Net7Supported Condition="'$(Net7Supported)'==''">true</Net7Supported>
<Net7Installed>false</Net7Installed>
<Net7Installed Condition="$(GlobalVersion.StartsWith('7.0'))">true</Net7Installed>
<Net7Installed Condition="'$(BUILD_NET7)'=='yes'">true</Net7Installed>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetStandard2Supported)'">$(TargetFrameworks);netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="'$(NetCore31Installed)' and '$(NetCore31Supported)'">$(TargetFrameworks);netcoreapp3.1</TargetFrameworks>
<TargetFrameworks Condition="'$(Net6Installed)' and '$(Net6Supported)'">$(TargetFrameworks);net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(Net7Installed)' and '$(Net7Supported)'">$(TargetFrameworks);net7.0</TargetFrameworks>
</PropertyGroup>
<PropertyGroup Condition="'$(OS)'=='Windows_NT'">
<TargetFrameworks Condition="'$(Framework462Installed)' and '$(Framework462Supported)'">$(TargetFrameworks);net462</TargetFrameworks>
Expand Down
2 changes: 1 addition & 1 deletion Samples/CloudMessaging/run-mock.cmd
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
cd %~dp0
dotnet ..\..\bin\net7.0\coyote.dll test /../bin/net7.0/Raft.Mocking.dll -i 1000 -ms 500 -graph-bug
dotnet ..\..\bin\net8.0\coyote.dll test /../bin/net8.0/Raft.Mocking.dll -i 1000 -ms 500 -graph-bug
2 changes: 1 addition & 1 deletion Samples/CloudMessaging/run-nondeterminism.cmd
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
cd %~dp0
dotnet ..\..\bin\net7.0\coyote.dll test ../bin/net7.0/Raft.Nondeterminism.dll -i 1000 -ms 500 -graph-bug
dotnet ..\..\bin\net8.0\coyote.dll test ../bin/net8.0/Raft.Nondeterminism.dll -i 1000 -ms 500 -graph-bug
2 changes: 1 addition & 1 deletion Samples/CloudMessaging/run.cmd
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dotnet %~dp0\..\bin\net7.0\Raft.Azure.dll --connection-string %CONNECTION_STRING% --topic-name rafttopic --num-requests 5 --local-cluster-size 5
dotnet %~dp0\..\bin\net8.0\Raft.Azure.dll --connection-string %CONNECTION_STRING% --topic-name rafttopic --num-requests 5 --local-cluster-size 5
2 changes: 1 addition & 1 deletion Samples/Common/TestDriver/rewrite.coyote.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"AssembliesPath": "../bin/net7.0",
"AssembliesPath": "../bin/net8.0",
"Assemblies": [
"AccountManager.dll",
"AccountManager.ETags.dll",
Expand Down
4 changes: 2 additions & 2 deletions Samples/Common/build.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<Product>CoyoteSamples</Product>
<Company>Microsoft Corporation</Company>
<Copyright>Copyright © Microsoft Corporation.</Copyright>
<LangVersion>10.0</LangVersion>
<TargetFrameworks>net7.0</TargetFrameworks>
<LangVersion>12.0</LangVersion>
<TargetFrameworks>net8.0</TargetFrameworks>
<UseLocalCoyote>False</UseLocalCoyote>
<UseLocalNugetPackages>False</UseLocalNugetPackages>
<UseNugetPackages>True</UseNugetPackages>
Expand Down
4 changes: 2 additions & 2 deletions Samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ to build reliable applications and services:

To build and run the samples, you will need to:

- Install the [.NET 7.0 SDK](https://dotnet.microsoft.com/download/dotnet).
- Install the [.NET 7.0 version of the coyote
- Install the [.NET 8.0 SDK](https://dotnet.microsoft.com/download/dotnet).
- Install the [.NET 8.0 version of the coyote
tool](https://microsoft.github.io/coyote/get-started/install/).

Once you are ready, build the samples by running the following script from the root of the
Expand Down
2 changes: 1 addition & 1 deletion Samples/Scripts/run-tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ CheckPSVersion

Write-Comment -prefix "." -text "Testing the Coyote samples" -color "yellow"

$framework = "net7.0"
$framework = "net8.0"
$tests = "$PSScriptRoot/../Common/bin/$framework/TestDriver.dll"
if (-not (Test-Path $tests)) {
Write-Error "tests for the Coyote samples not found."
Expand Down
18 changes: 9 additions & 9 deletions Samples/WebApps/ImageGalleryAspNet/ImageGallery/design.dgml
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@
<Alias n="93" Id="(@1 @21 @44 Member=(Name=Create OverloadingParameters=[@43]))" />
<Alias n="94" Id="(@1 @21 @44 Member=(Name=Update OverloadingParameters=[@43]))" />
<Alias n="95" Id="(@1 @21 @67 Member=(Name=Store OverloadingParameters=[@76]))" />
<Alias n="96" Uri="Assembly=file:///C:/Program Files/dotnet/packs/Microsoft.NETCore.App.Ref/7.0.100/ref/net7.0/System.Runtime.dll" />
<Alias n="96" Uri="Assembly=file:///C:/Program Files/dotnet/packs/Microsoft.NETCore.App.Ref/7.0.100/ref/net8.0/System.Runtime.dll" />
<Alias n="97" Id="(@96 Namespace=System Type=String)" />
<Alias n="98" Id="OverloadingParameters=[@97]" />
<Alias n="99" Id="(@1 @21 @44 Member=(Name=Get @98))" />
Expand Down Expand Up @@ -869,13 +869,13 @@
</Style>
</Styles>
<Paths>
<Path Id="a5b18c87-5523-45ca-ad7c-ba9f9cd970f0.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net7.0\ImageGalleryClient.dll" />
<Path Id="a5b18c87-5523-45ca-ad7c-ba9f9cd970f0.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net7.0/ImageGalleryClient.dll" />
<Path Id="b61697f0-7146-4c6a-8b6f-22f47731b799.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net7.0\ImageGalleryTests.dll" />
<Path Id="b61697f0-7146-4c6a-8b6f-22f47731b799.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net7.0/ImageGalleryTests.dll" />
<Path Id="c1ca4fb9-7c59-425f-b437-04cc48ba1988.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\ImageGallery\bin\Debug\net7.0\ImageGallery.dll" />
<Path Id="c1ca4fb9-7c59-425f-b437-04cc48ba1988.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/ImageGallery/bin/Debug/net7.0/ImageGallery.dll" />
<Path Id="e140c75e-8fc0-4c25-a744-2172d419a56a.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net7.0\ImageGalleryService.dll" />
<Path Id="e140c75e-8fc0-4c25-a744-2172d419a56a.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net7.0/ImageGalleryService.dll" />
<Path Id="a5b18c87-5523-45ca-ad7c-ba9f9cd970f0.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net8.0\ImageGalleryClient.dll" />
<Path Id="a5b18c87-5523-45ca-ad7c-ba9f9cd970f0.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net8.0/ImageGalleryClient.dll" />
<Path Id="b61697f0-7146-4c6a-8b6f-22f47731b799.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net8.0\ImageGalleryTests.dll" />
<Path Id="b61697f0-7146-4c6a-8b6f-22f47731b799.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net8.0/ImageGalleryTests.dll" />
<Path Id="c1ca4fb9-7c59-425f-b437-04cc48ba1988.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\ImageGallery\bin\Debug\net8.0\ImageGallery.dll" />
<Path Id="c1ca4fb9-7c59-425f-b437-04cc48ba1988.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/ImageGallery/bin/Debug/net8.0/ImageGallery.dll" />
<Path Id="e140c75e-8fc0-4c25-a744-2172d419a56a.OutputPath" Value="C:\git\microsoft\CoyoteSamples\ImageGalleryAspNet\bin\net8.0\ImageGalleryService.dll" />
<Path Id="e140c75e-8fc0-4c25-a744-2172d419a56a.OutputPathUri" Value="file:///C:/git/microsoft/CoyoteSamples/ImageGalleryAspNet/bin/net8.0/ImageGalleryService.dll" />
</Paths>
</DirectedGraph>
2 changes: 1 addition & 1 deletion Samples/WebApps/ImageGalleryAspNet/ImageGallery/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This is a web client front end that uses the ImageGalleryService middle tier.

The app depends on the following:

- [.NET 7.0 SDK](https://dotnet.microsoft.com/download/dotnet) must be installed.
- [.NET 8.0 SDK](https://dotnet.microsoft.com/download/dotnet) must be installed.
- [Azure Storage Emulator](https://docs.microsoft.com/en-us/azure/storage/common/storage-use-emulator) must be hnstalled running.
- [Azure Cosmos Emulator](https://docs.microsoft.com/en-us/azure/cosmos-db/local-emulator?tabs=cli%2Cssl-netstd21) must be installed and running.
- Open Azure Cosmos Data Explorer from taskbar tray and copy the `Primary Connection String` from there into `~/ImageGalleryAspNet/ImageGalleryService/appsettings.json`.
Expand Down
2 changes: 1 addition & 1 deletion Samples/WebApps/ImageGalleryAspNet/rewrite.coyote.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"AssembliesPath": "./bin/net7.0",
"AssembliesPath": "./bin/net8.0",
"OutputPath": "./bin/coyote",
"Assemblies": [
"ImageGalleryService.dll",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"AssembliesPath": "./bin/net7.0",
"AssembliesPath": "./bin/net8.0",
"Assemblies": [
"PetImages.dll",
"PetImages.Tests.dll"
Expand Down
35 changes: 35 additions & 0 deletions Scripts/CI/azure-nuget-sign-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ steps:
inputs:
versionSpec: 6.x

- task: UseDotNet@2
displayName: 'Install .NET 8.0 SDK'
inputs:
version: 8.0.x

- task: UseDotNet@2
displayName: 'Install .NET 7.0 SDK'
inputs:
Expand Down Expand Up @@ -38,6 +43,36 @@ steps:
failOnStderr: true
pwsh: true

- task: EsrpCodeSigning@2
displayName: 'ESRP CodeSigning .NET 8.0'
inputs:
ConnectedServiceName: CoyoteNugetSign
FolderPath: bin\net8.0
signConfigType: inlineSignParams
inlineOperation: |
[
{
"KeyCode": "CP-230012",
"OperationCode": "SigntoolSign",
"Parameters": {
"OpusName": "Microsoft.Coyote",
"OpusInfo": "https://github.com/Microsoft/Coyote",
"FileDigest": "/fd \"SHA256\"",
"PageHash": "/PH",
"TimeStamp": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256"
},
"ToolName": "sign",
"ToolVersion": "1.0"
},
{
"KeyCode": "CP-230012",
"OperationCode": "SigntoolVerify",
"Parameters": {},
"ToolName": "sign",
"ToolVersion": "1.0"
}
]

- task: EsrpCodeSigning@2
displayName: 'ESRP CodeSigning .NET 7.0'
inputs:
Expand Down
6 changes: 6 additions & 0 deletions Scripts/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ $dotnet_sdk_path = FindDotNetSdkPath -dotnet $dotnet
$version_net4 = $IsWindows -and (Get-ItemProperty "HKLM:SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full").Release -ge 528040
$version_netcore31 = FindMatchingVersion -path $dotnet_sdk_path -version "3.1.0"
$version_net6 = FindMatchingVersion -path $dotnet_sdk_path -version "6.0.0"
$version_net7 = FindMatchingVersion -path $dotnet_sdk_path -version "7.0.0"
$sdk_version = FindDotNetSdkVersion -dotnet_sdk_path $dotnet_sdk_path

if ($null -eq $sdk_version) {
Expand All @@ -53,6 +54,11 @@ if ($ci.IsPresent) {
# Build .NET 6.0 as well as the latest version.
$extra_frameworks = $extra_frameworks + " /p:BUILD_NET6=yes"
}

if ($null -ne $version_net7 -and $version_net7 -ne $sdk_version) {
# Build .NET 7.0 as well as the latest version.
$extra_frameworks = $extra_frameworks + " /p:BUILD_NET7=yes"
}
}

Write-Comment -text "Using configuration '$configuration'." -color "magenta"
Expand Down
2 changes: 1 addition & 1 deletion Scripts/common.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function Invoke-CoyoteTool([String]$cmd, [String]$dotnet, [String]$framework, [S
$command = "$coyote $cmd $target"
}

if ($command -eq "rewrite" -and $framework -ne "netcoreapp3.1" -and $framework -ne "net6.0" -and $framework -ne "net7.0" -and $IsWindows) {
if ($command -eq "rewrite" -and $framework -ne "netcoreapp3.1" -and $framework -ne "net6.0" -and $framework -ne "net7.0" -and $framework -ne "net8.0" -and $IsWindows) {
# NOTE: Mono.Cecil cannot sign assemblies on unix platforms.
$command = "$command -snk $key"
}
Expand Down
2 changes: 1 addition & 1 deletion Scripts/gen-docs.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

$root_dir = "$PSScriptRoot\.."
$packages_path = "$root_dir\packages"
$framework = "net7.0"
$framework = "net8.0"

Import-Module $PSScriptRoot\common.psm1 -Force

Expand Down
2 changes: 1 addition & 1 deletion Scripts/run-benchmark-history.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function RestoreBenchmark() {
Invoke-Expression "sed -i 's/\\Performance.Tests.csproj/\\Microsoft.Coyote.Performance.Tests.csproj/' $RootDir\Coyote.sln"
}

$benchmarks_dir = "$RootDir/Tools/BenchmarkRunner/bin/net7.0"
$benchmarks_dir = "$RootDir/Tools/BenchmarkRunner/bin/net8.0"
$benchmark_runner = "BenchmarkRunner.exe"
$index = 0

Expand Down
2 changes: 1 addition & 1 deletion Scripts/run-benchmarks.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if ($local -eq ""){
}

$current_dir = (Get-Item -Path "./").FullName
$benchmarks_dir = "$PSScriptRoot/../Tools/BenchmarkRunner/bin/net7.0"
$benchmarks_dir = "$PSScriptRoot/../Tools/BenchmarkRunner/bin/net8.0"
$benchmark_runner = "BenchmarkRunner.exe"
$artifacts_dir = "$current_dir/benchmark_$commit"

Expand Down
12 changes: 6 additions & 6 deletions Scripts/run-tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Licensed under the MIT License.

param(
[ValidateSet("net7.0", "net6.0", "netcoreapp3.1", "net462")]
[string]$framework = "net7.0",
[ValidateSet("net8.0", "net7.0", "net6.0", "netcoreapp3.1", "net462")]
[string]$framework = "net8.0",
[ValidateSet("all", "runtime", "rewriting", "testing", "actors", "actors-testing", "tools")]
[string]$test = "all",
[string]$filter = "",
Expand Down Expand Up @@ -53,12 +53,12 @@ foreach ($kvp in $targets.GetEnumerator()) {
}

$target = "$PSScriptRoot/../Tests/$($kvp.Value)/$($kvp.Value).csproj"
if ($f -eq "net7.0") {
if ($f -eq "net8.0") {
$AssemblyName = GetAssemblyName($target)
$command = [IO.Path]::Combine($PSScriptRoot, "..", "Tests", $($kvp.Value), "bin", "net7.0", "$AssemblyName.dll")
$command = [IO.Path]::Combine($PSScriptRoot, "..", "Tests", $($kvp.Value), "bin", "net8.0", "$AssemblyName.dll")
$command = $command + ' -r "' + [IO.Path]::Combine( `
$PSScriptRoot, "..", "Tests", $($kvp.Value), "bin", "net7.0", "*.dll") + '"'
$command = $command + ' -r "' + [IO.Path]::Combine($PSScriptRoot, "..", "bin", "net7.0", "*.dll") + '"'
$PSScriptRoot, "..", "Tests", $($kvp.Value), "bin", "net8.0", "*.dll") + '"'
$command = $command + ' -r "' + [IO.Path]::Combine($PSScriptRoot, "..", "bin", "net8.0", "*.dll") + '"'
$command = $command + ' -r "' + [IO.Path]::Combine($dotnet_runtime_path, $runtime_version, "*.dll") + '"'
$command = $command + ' -r "' + [IO.Path]::Combine($aspnet_runtime_path, $runtime_version, "*.dll") + '"'
Invoke-ToolCommand -tool $ilverify -cmd $command -error_msg "found corrupted assembly rewriting"
Expand Down
3 changes: 3 additions & 0 deletions Source/Core/Runtime/Exceptions/RuntimeException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ internal RuntimeException(string message, Exception innerException)
/// <summary>
/// Initializes a new instance of the <see cref="RuntimeException"/> class.
/// </summary>
#if NET8_0_OR_GREATER
[Obsolete("This method is obsolete due to BinaryFormatter obsoleted", DiagnosticId = "SYSLIB0051")]
#endif
protected RuntimeException(SerializationInfo serializationInfo, StreamingContext streamingContext)
: base(serializationInfo, streamingContext)
{
Expand Down
Loading
Loading