update to Playwright 1.39 (#331)

* update to Playwright 1.39
microsoft · Nov 15, 2023 · 770c223 · 770c223
1 parent ae757ee
commit 770c223
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 27 deletions.
diff --git a/.azurepipelines/contoso-traders-cloud-testing.yml b/.azurepipelines/contoso-traders-cloud-testing.yml
@@ -715,7 +715,7 @@ stages:
 
       - job: playwright_tests_ui
         dependsOn: [provision]
-        container: mcr.microsoft.com/playwright:v1.36.2-jammy
+        container: mcr.microsoft.com/playwright:v1.39.0-jammy
         variables:
           APIURLSHOPPINGCART: $[ dependencies.provision.outputs['getCartsApiEndpoint.cartsApiEndpoint'] ]
           APIURL: $[ dependencies.provision.outputs['getProductsApiEndpoint.productsApiEndpoint'] ]

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,6 +1,6 @@
 {
 	"name": "Playwright",
-	"image": "mcr.microsoft.com/playwright:v1.36.2-jammy",
+	"image": "mcr.microsoft.com/playwright:v1.39.0-jammy",
 	"features": {
 		"ghcr.io/devcontainers/features/node:1": {
 			"nodeGypDependencies": true,

diff --git a/.github/workflows/contoso-traders-cloud-testing.yml b/.github/workflows/contoso-traders-cloud-testing.yml
@@ -626,7 +626,7 @@ jobs:
     timeout-minutes: 20
     runs-on: ubuntu-22.04
     container:
-      image: mcr.microsoft.com/playwright:v1.36.2-jammy
+      image: mcr.microsoft.com/playwright:v1.39.0-jammy
     defaults:
       run:
         working-directory: src/ContosoTraders.Ui.Website
@@ -658,8 +658,7 @@ jobs:
         run: HOME=/root npx playwright test
       - name: upload playwright report
         uses: actions/upload-artifact@v3
-        # only upload report if tests failed
-        if: steps.test.outcome != 'success'
+        if: always()
         with:
           name: playwright-report
           path: src/ContosoTraders.Ui.Website/playwright-report/

diff --git a/src/ContosoTraders.Ui.Website/package-lock.json b/src/ContosoTraders.Ui.Website/package-lock.json
diff --git a/src/ContosoTraders.Ui.Website/package.json b/src/ContosoTraders.Ui.Website/package.json
@@ -45,7 +45,7 @@
     ]
   },
   "devDependencies": {
-    "@playwright/test": "1.36",
+    "@playwright/test": "^1.39.0",
     "@types/node": "^18.11.18",
     "babel-plugin-macros": "^3.1.0",
     "csv-parse": "^5.5.0",