-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSurfer Documentation and Fixes #4624
Conversation
Ready for review. Hopefully can be merged this week @afourney this shouldn't change how the websurfer works, but added tests/docs/cleanup/markitdown for summarization. Take your time in review, this will probably be how the code looks like for a while. @ekzhu I added tests for playwright controller and websurfer. I had to check private attributes for the test and so plastered "# pyright: ignore[reportPrivateUsage]" everywhere, don't know how to otherwise. I do not want to expose these attributes otherwise |
when reviewing, please take a look at how I changed the toml file to do playwright install, thanks! |
python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/_multimodal_web_surfer.py
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/_multimodal_web_surfer.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/_multimodal_web_surfer.py
Show resolved
Hide resolved
the test pass locally.. and passed before the latest commit while I didn't change any of the code functionally.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as per the discussion.
This should not change how the WebSurfer operates in any way except for summarization/QA tool.
Related issue number
Closes :
#4573
#4567
#4565
#4467