Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSurfer Documentation and Fixes #4624

Merged
merged 17 commits into from
Dec 12, 2024
Merged

WebSurfer Documentation and Fixes #4624

merged 17 commits into from
Dec 12, 2024

Conversation

husseinmozannar
Copy link
Contributor

@husseinmozannar husseinmozannar commented Dec 10, 2024

This should not change how the WebSurfer operates in any way except for summarization/QA tool.

  • adds documentation to web surfer
  • adds documentation to playwright controller and exposes it
  • cleans up code of web surfer
  • adds markdown converter for summarization tool
  • add on_message_stream with exposing inner messages
  • adds model usage stats to web surfer
  • add unit tests

Related issue number

Closes :
#4573
#4567
#4565
#4467

@husseinmozannar husseinmozannar marked this pull request as ready for review December 10, 2024 22:40
@husseinmozannar
Copy link
Contributor Author

husseinmozannar commented Dec 10, 2024

Ready for review. Hopefully can be merged this week

@afourney this shouldn't change how the websurfer works, but added tests/docs/cleanup/markitdown for summarization. Take your time in review, this will probably be how the code looks like for a while.

@ekzhu I added tests for playwright controller and websurfer. I had to check private attributes for the test and so plastered "# pyright: ignore[reportPrivateUsage]" everywhere, don't know how to otherwise. I do not want to expose these attributes otherwise

@husseinmozannar
Copy link
Contributor Author

when reviewing, please take a look at how I changed the toml file to do playwright install, thanks!

@husseinmozannar
Copy link
Contributor Author

the test pass locally.. and passed before the latest commit while I didn't change any of the code functionally..

Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as per the discussion.

@afourney afourney merged commit b9d682c into main Dec 12, 2024
48 checks passed
@afourney afourney deleted the web_surfer_fix branch December 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants