-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid pip syntax, use double quotes for portable version (zsh/windows) #4489
base: main
Are you sure you want to change the base?
Conversation
pip install command with single quotes results in the following error: (venv) C:\work\microsoft\autogen>pip install 'autogen-agentchat==0.4.0.dev8' 'autogen-ext[openai]==0.4.0.dev8' ERROR: Invalid requirement: "'autogen-agentchat==0.4.0.dev8'": Expected package name at the start of dependency specifier 'autogen-agentchat==0.4.0.dev8' ^
Ironically this will break usage in ZSH... Let's use double quotes. And while you at it, could you also help us fix the whole repo? |
yes, I will do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been changed except for updating the installation instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been changed except for updating the installation instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been changed except for updating the installation instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't have been changed except for updating the installation instructions.
I read your comments but IMO these are normal shell scripts, just inside a jupyter notebook cell, so we should update this also. We should maybe consider even to use "%pip install ..." instead of "pip install ...." in the ipynb files (with percentage) as this is a good practice (to enforce installation into the venv envionment). what do you think ? Reference: |
My comment was that I saw the outputs of the notebooks have been cleared -- we should keep them
I agree. |
ok, sorry i misunderstood you. I have a commit hook for jupyter file to clean the output :-)
cool, so i would change this to %pip install |
No worries. Yes please reset changes on those files and apply double quotes again. |
pip install command with single quotes results in the following error:
Why are these changes needed?
because it results in a pip syntax error
pip install command with single quotes results in the following error:
Related issue number
as this is a trivial change, i did not create a separate issue
Checks